Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247. #4250

Merged
merged 2 commits into from
Mar 12, 2020
Merged

[Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247. #4250

merged 2 commits into from
Mar 12, 2020

Conversation

akokhan
Copy link
Contributor

@akokhan akokhan commented Mar 11, 2020

Signed-off-by: Andriy Kokhan akokhan@barefootnetworks.com

- What I did
Added NAT entry into CONTAINER_FEATURE in config_db.json template

[Service] Added NAT entry into CONTAINER_FEATURE. Fixes sonic-net#4247.
cbc462d 
Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
@akokhan
Copy link
Contributor Author

akokhan commented Mar 11, 2020

@jleveque , @SavchukRomanLv , please have a look

msosyak
msosyak previously approved these changes Mar 11, 2020
View reviewed changes
jleveque
jleveque suggested changes Mar 11, 2020
View reviewed changes
files/build_templates/init_cfg.json.j2 Outdated Show resolved Hide resolved
@akokhan
Copy link
Contributor Author

akokhan commented Mar 11, 2020

retest vs

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest default please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest mellanox please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest vsimage please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest default please

1 similar comment
@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest default please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest vsimage please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest default please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest this please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest vs please

@akokhan
Copy link
Contributor Author

akokhan commented Mar 12, 2020

retest vsimage please

@lguohan lguohan merged commit 540cc78 into sonic-net:master Mar 12, 2020
@stepanblyschak stepanblyschak mentioned this pull request Mar 18, 2020
Closed
abdosi pushed a commit that referenced this pull request Mar 20, 2020
@akokhan @abdosi
[Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247. (#4250)
39889a3 
* [Service] Added NAT entry into CONTAINER_FEATURE. Fixes #4247.

Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@akokhan @tiantianlv
[Service] Added NAT entry into CONTAINER_FEATURE. Fixes sonic-net#4247.…
d346319 
… (sonic-net#4250)

* [Service] Added NAT entry into CONTAINER_FEATURE. Fixes sonic-net#4247.

Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

@msosyak msosyak msosyak left review comments

Assignees
No one assigned
Labels
Bug 🐛 Included in 201911 Branch Request for 201911 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akokhan @lguohan @jleveque @msosyak @stepanblyschak @abdosi